Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
Y
yii2
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
PSDI Army
yii2
Commits
78a8694e
Commit
78a8694e
authored
Apr 25, 2014
by
Carsten Brandt
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
file helper did not preserve relative paths
parent
e3463303
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
1 deletion
+9
-1
BaseFileHelper.php
framework/helpers/BaseFileHelper.php
+1
-1
FileHelperTest.php
tests/unit/framework/helpers/FileHelperTest.php
+8
-0
No files found.
framework/helpers/BaseFileHelper.php
View file @
78a8694e
...
@@ -48,7 +48,7 @@ class BaseFileHelper
...
@@ -48,7 +48,7 @@ class BaseFileHelper
// the path may contain ".", ".." or double slashes, need to clean them up
// the path may contain ".", ".." or double slashes, need to clean them up
$parts
=
[];
$parts
=
[];
foreach
(
explode
(
$ds
,
$path
)
as
$part
)
{
foreach
(
explode
(
$ds
,
$path
)
as
$part
)
{
if
(
$part
===
'..'
&&
!
empty
(
$parts
))
{
if
(
$part
===
'..'
&&
!
empty
(
$parts
)
&&
end
(
$parts
)
!==
'..'
)
{
array_pop
(
$parts
);
array_pop
(
$parts
);
}
elseif
(
$part
===
'.'
||
$part
===
''
&&
!
empty
(
$parts
))
{
}
elseif
(
$part
===
'.'
||
$part
===
''
&&
!
empty
(
$parts
))
{
continue
;
continue
;
...
...
tests/unit/framework/helpers/FileHelperTest.php
View file @
78a8694e
...
@@ -367,6 +367,14 @@ class FileHelperTest extends TestCase
...
@@ -367,6 +367,14 @@ class FileHelperTest extends TestCase
$this
->
assertEquals
(
"
{
$ds
}
c"
,
FileHelper
::
normalizePath
(
'/a/.\\b//../../c'
));
$this
->
assertEquals
(
"
{
$ds
}
c"
,
FileHelper
::
normalizePath
(
'/a/.\\b//../../c'
));
$this
->
assertEquals
(
"c"
,
FileHelper
::
normalizePath
(
'/a/.\\b/../..//../c'
));
$this
->
assertEquals
(
"c"
,
FileHelper
::
normalizePath
(
'/a/.\\b/../..//../c'
));
$this
->
assertEquals
(
"..
{
$ds
}
c"
,
FileHelper
::
normalizePath
(
'//a/.\\b//..//..//../../c'
));
$this
->
assertEquals
(
"..
{
$ds
}
c"
,
FileHelper
::
normalizePath
(
'//a/.\\b//..//..//../../c'
));
// relative paths
$this
->
assertEquals
(
"..
{
$ds
}
..
{
$ds
}
a"
,
FileHelper
::
normalizePath
(
'../..\\a'
));
$this
->
assertEquals
(
"..
{
$ds
}
..
{
$ds
}
a"
,
FileHelper
::
normalizePath
(
'../..\\a/../a'
));
$this
->
assertEquals
(
"..
{
$ds
}
..
{
$ds
}
b"
,
FileHelper
::
normalizePath
(
'../..\\a/../b'
));
$this
->
assertEquals
(
"..
{
$ds
}
a"
,
FileHelper
::
normalizePath
(
'./..\\a'
));
$this
->
assertEquals
(
"..
{
$ds
}
a"
,
FileHelper
::
normalizePath
(
'./..\\a/../a'
));
$this
->
assertEquals
(
"..
{
$ds
}
b"
,
FileHelper
::
normalizePath
(
'./..\\a/../b'
));
}
}
public
function
testLocalizedDirectory
()
public
function
testLocalizedDirectory
()
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment